Liquidsoap

Several bugs when testing a (very dumb) videoconference example

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

I have attached a script that demonstrates a simple high latency video conference system using only liquidsoap: each party sends one stream using output.harbor() and receives another one using input.http().

Without gavl, it does not segfault, but the video inputs fail to decode any data. It gets a little better (sometimes) if catch more errors in ogg_decoder.ml.

With gavl enabled, this segfaults rather quickly, with this kind of backtrace:
0xb760524e in yuvj_420_p_to_rgba_32_mmx (ctx=0x855a138) at ../csp_planar_packed.h:101
101 ../csp_planar_packed.h: No such file or directory.
in ../csp_planar_packed.h
(gdb) bt
#0 0xb760524e in yuvj_420_p_to_rgba_32_mmx (ctx=0x855a138)
at ../csp_planar_packed.h:101
#1 0xb75cc926 in gavl_video_convert (cnv=0x858e318, input_frame=0x8586338,
output_frame=0xb3625080) at video.c:517
#2 0x083339ab in caml_gavl_vid_conv_convert (conv=-1251462924, old=-1239830304,
new=-1239830216) at gavl_stubs.c:583
#3 0x081ce1b3 in camlGavl_converter__convert_1095 ()
#4 0xb56830f4 in ?? ()

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Samuel Mimram added a comment -
David, I think that you forgot to attach the liq files showing the problem... (I'm I missing something ?) Can you find them back? Without them this BR is of little use...
Show
Samuel Mimram added a comment - David, I think that you forgot to attach the liq files showing the problem... (I'm I missing something ?) Can you find them back? Without them this BR is of little use...
Hide
Permalink
David Baelde added a comment -
Thanks for pointing this out. Fortunately I haven't lost the file, here it is.
Show
David Baelde added a comment - Thanks for pointing this out. Fortunately I haven't lost the file, here it is.
Hide
Permalink
Samuel Mimram added a comment -
Same bug here! However with set("video.converter.preferred","native") it (sometimes) works... :)
Show
Samuel Mimram added a comment - Same bug here! However with set("video.converter.preferred","native") it (sometimes) works... :)
Hide
Permalink
Samuel Mimram added a comment -
The GAVL bug seems to have been fixed by my magic git patch 903803c5a49659344687a91956e4aad824c39ce8. Now, if you wait long enough, the videos will sync as expected :)

Talking with Romain, it appears that it is difficult to take an ogg stream in the middle and so it's expected that Liq takes some time to be able to decode the stream. So, maybe could we mark this as resolved?
Show
Samuel Mimram added a comment - The GAVL bug seems to have been fixed by my magic git patch 903803c5a49659344687a91956e4aad824c39ce8. Now, if you wait long enough, the videos will sync as expected :) Talking with Romain, it appears that it is difficult to take an ogg stream in the middle and so it's expected that Liq takes some time to be able to decode the stream. So, maybe could we mark this as resolved?
Hide
Permalink
David Baelde added a comment -
As far as I remember it works fine for me since I fixed the exception handling in the ogg decoder (with Romain's help). I can double check but I'm happy to mark as fixed. (BTW, gavl hasn't been an issue for me because I don't use it.)
Show
David Baelde added a comment - As far as I remember it works fine for me since I fixed the exception handling in the ogg decoder (with Romain's help). I can double check but I'm happy to mark as fixed. (BTW, gavl hasn't been an issue for me because I don't use it.)
Hide
Permalink
Samuel Mimram added a comment -
Ok. Let's close this issue and live happily ever after.
Show
Samuel Mimram added a comment - Ok. Let's close this issue and live happily ever after.

People

  • Assignee:
    Romain Beauxis
    Reporter:
    David Baelde
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: