Liquidsoap

Audio-audio mux

Details

  • Type: New Feature New Feature
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0
  • Component/s: None
  • Labels:
    None

Description

We can mux video into non-video streams, audio into non-audio, but can't mux audio into audio. A general operator requires type-level addition (N audio and M audio yields N+M audio) which we don't have, but a simpler version seems easily feasible and would be useful. Namely, I propose mux_mono which takes a (1,0,0) and a (x,y,z) source and returns an (x+1,y,z) source, and similarly a mux_stereo operator.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dave Pascoe added a comment -
Based on what I know, this seems like a reasonable approach.
Show
Dave Pascoe added a comment - Based on what I know, this seems like a reasonable approach.
Hide
Permalink
David Baelde added a comment -
I committed a proposal in branch LS-556. Please test it (hg pull ; hg up LS-556 ; make) and tell me how you like it.

Currently I had to disable an optimization to make it work as expected. I'll have to work a little bit to re-enable it -- without the optim, conversions may be a bit expensive.
Show
David Baelde added a comment - I committed a proposal in branch LS-556 . Please test it (hg pull ; hg up LS-556 ; make) and tell me how you like it. Currently I had to disable an optimization to make it work as expected. I'll have to work a little bit to re-enable it -- without the optim, conversions may be a bit expensive.
Hide
Permalink
Dave Pascoe added a comment -
I have LS-556 running...with this script I am getting only input1 on both the left and right channel. Also verified with sound mixer L-R control. Do I have the syntax right?

#!/usr/bin/liquidsoap

url1 = "http://host:port/stream1"
input1 = mksafe(input.http(url1))
url2 = "http://host:port/stream2"
input2 = mksafe(input.http(url2))

s = mux_mono(mono=input1,input2)

output.icecast(%mp3(samplerate=22050, bitrate=16, stereo=true),host="host",port=8000,password="xxxx",mount="muxmonotest", icy_metadata="true", name="mux_mono test", restart=true, public=false,s)
Show
Dave Pascoe added a comment - I have LS-556 running...with this script I am getting only input1 on both the left and right channel. Also verified with sound mixer L-R control. Do I have the syntax right? #!/usr/bin/liquidsoap url1 = " http://host:port/stream1 " input1 = mksafe(input.http(url1)) url2 = " http://host:port/stream2 " input2 = mksafe(input.http(url2)) s = mux_mono(mono=input1,input2) output.icecast(%mp3(samplerate=22050, bitrate=16, stereo=true),host="host",port=8000,password="xxxx",mount="muxmonotest", icy_metadata="true", name="mux_mono test", restart=true, public=false,s)
Hide
Permalink
David Baelde added a comment -
Hi Dave, thanks for the test. You script is good, and the bug looks like the one I observed. Apparently disabling the optimization wasn't enough to make it go away. I'll investigate this soon, and I'll let you know.
Show
David Baelde added a comment - Hi Dave, thanks for the test. You script is good, and the bug looks like the one I observed. Apparently disabling the optimization wasn't enough to make it go away. I'll investigate this soon, and I'll let you know.
Hide
Permalink
Dave Pascoe added a comment -
No worries...let me know what I can do whenever you have time.
Show
Dave Pascoe added a comment - No worries...let me know what I can do whenever you have time.
Hide
Permalink
David Baelde added a comment -
I just committed another change, it addresses more problems and various tests involving mux_mono, mean and files are convincing. More testing would be welcome, of course. However, I remember from playing with mono HTTP input that it had its own problems. Do report such problems, but preferably in LS-565. While testing, don't hesitate to use type annotations to make sure streams have the expected type, for example write (sine():source(1,0,0)) if you want only a mono sine.

The code still needs to be documented and cleaned up a bit, and I haven't completely made up my mind about the new optimization API, but I'm hopeful that this issue can be closed quickly now.
Show
David Baelde added a comment - I just committed another change, it addresses more problems and various tests involving mux_mono, mean and files are convincing. More testing would be welcome, of course. However, I remember from playing with mono HTTP input that it had its own problems. Do report such problems, but preferably in LS-565 . While testing, don't hesitate to use type annotations to make sure streams have the expected type, for example write (sine():source(1,0,0)) if you want only a mono sine. The code still needs to be documented and cleaned up a bit, and I haven't completely made up my mind about the new optimization API, but I'm hopeful that this issue can be closed quickly now.
Hide
Permalink
David Baelde added a comment -
Fixed in 7cc8a8b53681
Show
David Baelde added a comment - Fixed in 7cc8a8b53681

People

  • Assignee:
    David Baelde
    Reporter:
    David Baelde
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: