Liquidsoap

Harbor and http buffer looses its data when decoding ogg data

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 0.9.3
  • Fix Version/s: 1.0
  • Component/s: Liquidsoap
  • Labels:
    None

Description

Harbor and http buffers loose data at each new track when decoding ogg/vorbis data.

This issue is also present in 0.9.2 and probably earlier.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Samuel Mimram added a comment -
Since the issue appeared recently and you can easily reproduce, maybe could you try to bissect?
Show
Samuel Mimram added a comment - Since the issue appeared recently and you can easily reproduce, maybe could you try to bissect?
Hide
Permalink
Romain Beauxis added a comment -
Yep! I'm actually trying to isolate precisely the issue and then I'll go for the bisection..
Show
Romain Beauxis added a comment - Yep! I'm actually trying to isolate precisely the issue and then I'll go for the bisection..
Hide
Permalink
Romain Beauxis added a comment -
A proper vorbis example..
Show
Romain Beauxis added a comment - A proper vorbis example..
Hide
Permalink
Romain Beauxis added a comment -
Ok, so here's a way to reproduce quickly:
Set up one harbor:
  ./liquidsoap 'set("log.level",5) output.dummy(fallible=true,input.harbor("test",logfile="/tmp/buffer.log"))'

Connect it to another local output:
  ./liquidsoap 'output.icecast(%vorbis,single("/tmp/foo.mp3"),mount="test",port=8005)'
where foo.mp3 is a small file.

The resulting graph is attached.

I have also experienced this with 0.9.2 but I am not sure if this related..

Coming back to the issue: the encoded vorbis data produced by liquidsoap is 100% correct and there does not seem to be any missing audio data..

However, during metadata update, there is a network data overhead for transmitting end of stream/beginning of stream. I am suspecting that the harbor input decoder never catchup from that and that this is the problem.

If this is true then the problem is not specific to vorbis and could also happen in case of temporary network lags. If they are less than a second, we will not see then in the log either..

What I do not understand is why the decoding thread never catches up.
Show
Romain Beauxis added a comment - Ok, so here's a way to reproduce quickly: Set up one harbor:   ./liquidsoap 'set("log.level",5) output.dummy(fallible=true,input.harbor("test",logfile="/tmp/buffer.log"))' Connect it to another local output:   ./liquidsoap 'output.icecast(%vorbis,single("/tmp/foo.mp3"),mount="test",port=8005)' where foo.mp3 is a small file. The resulting graph is attached. I have also experienced this with 0.9.2 but I am not sure if this related.. Coming back to the issue: the encoded vorbis data produced by liquidsoap is 100% correct and there does not seem to be any missing audio data.. However, during metadata update, there is a network data overhead for transmitting end of stream/beginning of stream. I am suspecting that the harbor input decoder never catchup from that and that this is the problem. If this is true then the problem is not specific to vorbis and could also happen in case of temporary network lags. If they are less than a second, we will not see then in the log either.. What I do not understand is why the decoding thread never catches up.
Hide
Permalink
Romain Beauxis added a comment -
Fixed in 6c1a7d8ce65a
Show
Romain Beauxis added a comment - Fixed in 6c1a7d8ce65a

People

  • Assignee:
    Unassigned
    Reporter:
    Romain Beauxis
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: