Liquidsoap

Clean handling of erroneous URLs

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

From the mailing-list:

out(mksafe(
fallback([
    input.http(id="h1","http://localhost:2345/radio"),
    single("say:fallback")
])
))

h1.url http:/localhost:2345/radio
h1.stop
h1.start

results in

2011/02/07 03:10:57 [threads:1] Thread "http polling" failed: Invalid
URL "http:/localhost:2345/radio"!!
Thread 4 killed on uncaught exception Failure("Invalid URL
"http:/localhost:2345/radio"!")
Raised at file "pervasives.ml", line 22, characters 22-33
2011/02/07 03:10:57 [main:3] Shutdown started!
2011/02/07 03:10:57 [main:3] Waiting for threads to terminate...

We should handle more cleanly ill-formed URLs.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Baelde added a comment -
Same issue with playlist.safe which crashes if an invalid reload is performed.
Show
David Baelde added a comment - Same issue with playlist.safe which crashes if an invalid reload is performed.
Hide
Permalink
David Baelde added a comment -
I have committed a simple fix. The syntax errors are never raised to toplevel anymore: for the initial URL, they are turned into the usual Invalid_value (which allows for a precise error message) and for the <source>.uri command invalid URLs are rejected upfront. Note that this fix still allows you to set a new valid URL to which the source may not be able to connect.
Show
David Baelde added a comment - I have committed a simple fix. The syntax errors are never raised to toplevel anymore: for the initial URL, they are turned into the usual Invalid_value (which allows for a precise error message) and for the <source>.uri command invalid URLs are rejected upfront. Note that this fix still allows you to set a new valid URL to which the source may not be able to connect.
Hide
Permalink
David Baelde added a comment -
Ignore my old comment about playlist.safe: the code is already solid enough, it filters out invalid entries and rejects the new playlist if it is empty, so an invalid new playlist would be ignored by playlist.safe() as expected.
Show
David Baelde added a comment - Ignore my old comment about playlist.safe: the code is already solid enough, it filters out invalid entries and rejects the new playlist if it is empty, so an invalid new playlist would be ignored by playlist.safe() as expected.

People

  • Assignee:
    David Baelde
    Reporter:
    Samuel Mimram
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: