Liquidsoap

Filter produces silence

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    SVN version

Description

A low-pass filter lets more and more go through as the frequency is increased, but when I reach 10000 nothing passes anymore.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Samuel Mimram added a comment -
Fixed in e6846a0dcce7.
Show
Samuel Mimram added a comment - Fixed in e6846a0dcce7.
Hide
Permalink
Samuel Mimram added a comment -
Actually the fix was bogus. I added comments about the situation in the source in d67f8f721312.
Show
Samuel Mimram added a comment - Actually the fix was bogus. I added comments about the situation in the source in d67f8f721312.
Hide
Permalink
Samuel Mimram added a comment -
So that people know, the problem with this filter is that the algo only handles freq <= rate/4, we have to find something better. See http://www.musicdsp.org/showArchiveComment.php?ArchiveID=23

Maybe should we implement Chamberlin's version instead, which handles freq <= rate/2 (see http://www.musicdsp.org/archive.php?classid=3#142 ) but it does not entirely fix the situation...
Show
Samuel Mimram added a comment - So that people know, the problem with this filter is that the algo only handles freq <= rate/4, we have to find something better. See http://www.musicdsp.org/showArchiveComment.php?ArchiveID=23 Maybe should we implement Chamberlin's version instead, which handles freq <= rate/2 (see http://www.musicdsp.org/archive.php?classid=3#142 ) but it does not entirely fix the situation...
Hide
Permalink
David Baelde added a comment -
Thanks for looking into this. The freq<=rate/2 thing is really interesting! If it's not an easy fix, I guess it'll wait for after 1.0, right? By the way, I don't see d67f8f721312 in the repository. You might not have pushed it. (And don't hesitate to branch!)
Show
David Baelde added a comment - Thanks for looking into this. The freq<=rate/2 thing is really interesting! If it's not an easy fix, I guess it'll wait for after 1.0, right? By the way, I don't see d67f8f721312 in the repository. You might not have pushed it. (And don't hesitate to branch!)
Hide
Permalink
David Baelde added a comment -
My bad, the changeset you mentioned is in the repo, obviously.
Show
David Baelde added a comment - My bad, the changeset you mentioned is in the repo, obviously.

People

  • Assignee:
    Samuel Mimram
    Reporter:
    David Baelde
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: