External encoder will not shutdown when liquidsoap is killed

Andrey Podshivalov added a comment - 03/Nov/10 6:42 PM Hi ! Thanks for the report ! The code for the external decoder has completely rewriten in the SVN. Are you able to test the SVN version (not necessarily in production) to see if this issue happens there also ? Ok, I was able to compile revision 7333 ok, but when I go to run liquidsoap I get this error: At 01-externals.liq, line 3, char 16: unbound symbol test_process. Thoughts? Yes, its a bug I need to fix ASAP... We have a problem in the inclusion of external scripts. You should be able to fix this quick and dirty by adding the test_process definition in 01-externals.liq (located at /usr/local/lib/liquidsoap/svn): {{{ # Return true if process exited with 0 code. # Command should return quickly. # @category System # @param command Command to test def test_process(command)   lines =     get_process_lines("(" ^ command ^ " >/dev/null 2>&1 && echo 0) || echo 1")   if list.length(lines) == 0 then     false   else     "0" == list.hd(lines)   end end }}} Ok, that fixed that error, but now I get this: At 01-externals.liq, line 29, char 22: unbound symbol get_mime Grrrr.. :-) Thanks, both issues are fixed now, you can kjust checkout the latest file from the SVN and reinstall.. on revision 7336: liquidsoap -c liquidsoap.liq File "01-externals.liq", line 3, char 2 before "%": Parse error. :-) This is fixed, my bad. Ok, that seems to fix those errors, but now i am getting these ones: At line 11, char 22: unbound symbol output.icecast.vorbis. and At line 11, char 26: unbound symbol output.icecast.aacplusenc. Has something changed? I have attached my config. Yes, the output operators have been made more modular: {{{ output.icecast.vorbis(..) }}} is now: {{{ output.icecast(%vorbis, ...) }}} and, {{{ output.icecast.aacplusenc(...) }}} Has not yet been standardised, so it will be something of the form: {{{ output.icecast(%external("/path/to/aacplusenc - - 32"),icy_metadata=true,format="audio/aacp",...) }}} Thank you for your patience !! Hmm, I can't seem to figure out the aacplusenc syntax. Do you have an example that I could look at? I have attached my config file (liquidsoap2.liq) It fails with this error: ERROR: This script is not well typed! At line 14, char 20-23: cannot apply that parameter because the function (at line 11, char 15) has no argument labeled "restart_on_crash"! And if I remove the restart info, I get the following: At line 12, char 16-19:   this value has type     bool   but it should be a subtype of     string Where line 12 is:   icy_metadata=true, Any ideas? Yes, sorry again. We are still busy changing the code and the documentation will follow later. Also, I reply to quickly without checking.. The documentation for the icy_metadata option is {{{ * icy_metadata : string (default "guess")     Send new metadata using the ICY protocol. One of: "guess", "true", "false" }}} so I guess you want {{{icy_metadata="true"}}}. The {{{restart_on_crash}}} option now belongs to the encoding format, so you may do: {{{ output.icecast(%external("/path/to/aacplusenc - - 32",restart_on_crash=true),icy_metadata="true", ...) }}} Thanks I got it working. And it appears that the bug has been resolved in SVN! Is it safe to run this version in production? Are there any glaring bugs? When will the next stable release be? Hi ! Nice to read that the bug is closed ! As for the stability of the SVN, I use it in production for a radio with multiple streams, crossfade and some other advanced features. I would say that SVN is usable for audio streaming, though, as always, you may still be ready to face some issues. As for the next stable release, this may take a little more time. The video part is a huge change and we will have to ge through a beta release cycle first. We still expect the first beta to be available soon..