Airtime

Use invoke-rc.d to start and stop services, rather than calling init scripts directly

Details

  • Originating Party:
    Developer

Description

The maintainer script calls scripts in init.d directly (well, indirectly,
  but without using invoke-rc.d):
  postinst -> airtime-install -> airtime-initialize.sh -> /etc.init.d/monit

See:

9.3.3 Interfacing with the initscript system

on the page:

http://www.debian.org/doc/debian-policy/ch-opersys.html

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Konecny added a comment -
HI Daniel,

It appears we only need to do this change in the Debian package according to the Debian Policy Manual. In that case, there are no upstream changes to be made.
Show
Martin Konecny added a comment - HI Daniel, It appears we only need to do this change in the Debian package according to the Debian Policy Manual. In that case, there are no upstream changes to be made.
Hide
Permalink
Daniel James added a comment -
Hi Martin, this fix is for line 46 of the install_minimal/include/airtime-initialize.sh script, it should really be fixed upstream in the 2.0.x-deb-official branch.

It's a simple fix, just replacing the line:

/etc/init.d/monit restart

with:

      if which invoke-rc.d >/dev/null 2>&1; then
      invoke-rc.d monit restart
      else
      /etc/init.d/monit restart
      fi
Show
Daniel James added a comment - Hi Martin, this fix is for line 46 of the install_minimal/include/airtime-initialize.sh script, it should really be fixed upstream in the 2.0.x-deb-official branch. It's a simple fix, just replacing the line: /etc/init.d/monit restart with:       if which invoke-rc.d >/dev/null 2>&1; then       invoke-rc.d monit restart       else       /etc/init.d/monit restart       fi
Hide
Permalink
Martin Konecny added a comment -
Ok will do this.
Show
Martin Konecny added a comment - Ok will do this.

People

  • Assignee:
    Martin Konecny
    Reporter:
    Daniel James
    Implemented by:
    Martin Konecny
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: