Airtime

Overbooked shows do not respect default fade time

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.2.0
  • Fix Version/s: 2.2.0
  • Component/s: Audio Player (pypo)
  • Labels:
    None
  • Originating Party:
    QA
  • OS:
    Ubuntu 10.04
  • Browser:
    Firefox

Description

At the end of an overbooked show, the audio output is cut instantly, instead of faded out. This is likely to result in a bad audio clash with the start of the next show. Overbooked shows could be faded out according to the default fade time set in the Preferences page.

Issue Links

depends on

Bug - A problem which impairs or prevents the functions of the product. CC-3626 Playlist Builder -> you can not add files from Library by using "+" button (if default Fades were changed in Preferences)

  • Blocker - Blocks development and/or testing work, production could not run.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. CC-3639 Preferences-> Fade In is interpreted improperly (it is insanely high)

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Paul made changes -
Field Original Value New Value
Assignee Martin Konecny [ mkonecny ]
Hide
Permalink
Martin Konecny added a comment -
i've sent an email to the liquidsoap team. Seems no way to abruptly end a song and fade out at any given moment (currently fade out point needs to be preset when loading the song)
Show
Martin Konecny added a comment - i've sent an email to the liquidsoap team. Seems no way to abruptly end a song and fade out at any given moment (currently fade out point needs to be preset when loading the song)
Hide
Permalink
Daniel James added a comment -
Hi Martin, the final audio file in the overbooked show does not need to be faded on-the-fly, because at the time when the overbooked show is created, Airtime already detects that (to issue the warning message about overbooking). All that needs to happen is for the correct cue-out point and default fade time to be applied to the playlist at the end of the overbooked show, as soon as a show with overbooking is saved in the calendar. That way, we can make sure that all shows have correct endings in advance of playout.

It might be beneficial to fade out all shows by default. Just suppose a presenter uploads a single pre-mixed file containing their show content, which is cut to the exact length of the show, but does not fade out at the end. This could also sound bad at the changeover time between shows, even though it was not overbooked.
Show
Daniel James added a comment - Hi Martin, the final audio file in the overbooked show does not need to be faded on-the-fly, because at the time when the overbooked show is created, Airtime already detects that (to issue the warning message about overbooking). All that needs to happen is for the correct cue-out point and default fade time to be applied to the playlist at the end of the overbooked show, as soon as a show with overbooking is saved in the calendar. That way, we can make sure that all shows have correct endings in advance of playout. It might be beneficial to fade out all shows by default. Just suppose a presenter uploads a single pre-mixed file containing their show content, which is cut to the exact length of the show, but does not fade out at the end. This could also sound bad at the changeover time between shows, even though it was not overbooked.
Martin Konecny made changes -
Fix Version/s 1.9.0 - Feature Freeze [ 10350 ]
Fix Version/s 1.8.1 [ 10420 ]
Paul made changes -
Fix Version/s 1.9.0 - Feature Freeze [ 10433 ]
Fix Version/s 1.8.2 - Feature Freeze [ 10350 ]
Paul made changes -
Component/s Audio Player (pypo) [ 10077 ]
Paul made changes -
Original Estimate 2 days [ 57600 ]
Remaining Estimate 2 days [ 57600 ]
Hide
Permalink
Martin Konecny added a comment -
Hi Daniel,

The problem with this approach is that we are trusting the track length obtained from the metadata which I don't want to do. The better way is to use our background daemons determine whether a show is still scheduled, and if not, tell liquidsoap to stop its output.
Show
Martin Konecny added a comment - Hi Daniel, The problem with this approach is that we are trusting the track length obtained from the metadata which I don't want to do. The better way is to use our background daemons determine whether a show is still scheduled, and if not, tell liquidsoap to stop its output.
Paul made changes -
Fix Version/s 1.9.0 - Beta 2 [ 10435 ]
Fix Version/s 1.9.0 - Beta 1 [ 10433 ]
Paul made changes -
Fix Version/s 1.9.0 - RC1 [ 10447 ]
Fix Version/s 1.9.0 - Beta 2 [ 10435 ]
Paul made changes -
Issue Type Bug [ 1 ] Improvement [ 4 ]
Assignee Martin Konecny [ mkonecny ]
Fix Version/s 2.0.0 - Beta 1 [ 10362 ]
Fix Version/s 1.9.0 - Beta 3 [ 10447 ]
Paul made changes -
Fix Version/s 2.1.0 - Feature Freeze [ 10363 ]
Fix Version/s 2.0.0 - Beta 1 [ 10362 ]
Hide
Permalink
Daniel James added a comment -
Hi Martin, we don't want to stop liquidsoap, we want a smooth fade down before the start point of the next show (not a crossfade, that might also clash). Try overbooking a loud show right before another loud show starts, it sounds pretty bad right now.

I don't see the difference between inserting a fade manually at the end of a scheduled playlist, and inserting a fade automatically at the point in the playlist which matches the end time of the show.

If the track length from the metadata cannot be trusted, this affects manually and automatically set fades in the same way. Perhaps the media monitor should check that the actual file length matches the metadata, and correct the metadata if required. For example if I edit a file in an external program to change the length, but the editor I use does not update the metadata.
Show
Daniel James added a comment - Hi Martin, we don't want to stop liquidsoap, we want a smooth fade down before the start point of the next show (not a crossfade, that might also clash). Try overbooking a loud show right before another loud show starts, it sounds pretty bad right now. I don't see the difference between inserting a fade manually at the end of a scheduled playlist, and inserting a fade automatically at the point in the playlist which matches the end time of the show. If the track length from the metadata cannot be trusted, this affects manually and automatically set fades in the same way. Perhaps the media monitor should check that the actual file length matches the metadata, and correct the metadata if required. For example if I edit a file in an external program to change the length, but the editor I use does not update the metadata.
Daniel James made changes -
Assignee Paul Baranowski [ paul ]
Paul made changes -
Fix Version/s 2.1.0 - Beta 1 [ 10362 ]
Fix Version/s 2.2.0 [ 10363 ]
Paul made changes -
Priority Critical [ 2 ] Blocker [ 1 ]
Paul made changes -
Assignee Paul Baranowski [ paul ] James Moon [ james.moon ]
Martin Konecny made changes -
Assignee James Moon [ james.moon ] Martin Konecny [ mkonecny ]
Martin Konecny made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Martin Konecny [ mkonecny ] Mikayel Karapetyan [ migelek ]
Implemented by mkonecny
Resolution Fixed [ 1 ]
Hide
Permalink
Mikayel Karapetyan added a comment -
1) I set the Default Fades=5.0 sec
2) created an overbooked show
3) waited till show starts and ends

Obtained result:
Overbooked Show does not respect the Fade Out and being Cut off instantly

Tested on 30-03-2012
Reopening
Show
Mikayel Karapetyan added a comment - 1) I set the Default Fades=5.0 sec 2) created an overbooked show 3) waited till show starts and ends Obtained result: Overbooked Show does not respect the Fade Out and being Cut off instantly Tested on 30-03-2012 Reopening
Mikayel Karapetyan made changes -
Status Resolved [ 5 ] Open [ 1 ]
Resolution Fixed [ 1 ]
Paul made changes -
Assignee Mikayel Karapetyan [ migelek ] Martin Konecny [ mkonecny ]
Martin Konecny made changes -
Assignee Martin Konecny [ mkonecny ] James Moon [ james.moon ]
Hide
Permalink
James Moon added a comment -
I'm not able to reproduce this bug. This must be fixed in other fade related bug.
Show
James Moon added a comment - I'm not able to reproduce this bug. This must be fixed in other fade related bug.
James Moon made changes -
Status Open [ 1 ] In Review [ 10000 ]
Assignee James Moon [ james.moon ] Martin Konecny [ mkonecny ]
Martin Konecny made changes -
Status In Review [ 10000 ] Resolved [ 5 ]
Assignee Martin Konecny [ mkonecny ] Mikayel Karapetyan [ migelek ]
Resolution Fixed [ 1 ]
Mikayel Karapetyan made changes -
Link This issue depends on CC-3626 [ CC-3626 ]
Hide
Permalink
Mikayel Karapetyan added a comment -
I am pretty sure this bug still persists (based on my judgements on other test scenarios)
It is not possible to test it though because of its dependency on http://dev.sourcefabric.org/browse/CC-3626
Show
Mikayel Karapetyan added a comment - I am pretty sure this bug still persists (based on my judgements on other test scenarios) It is not possible to test it though because of its dependency on http://dev.sourcefabric.org/browse/CC-3626
Mikayel Karapetyan made changes -
Link This issue depends on CC-3639 [ CC-3639 ]
Hide
Permalink
Mikayel Karapetyan added a comment -
now the overbooked show gracefully exits.
verified on Airtime 2.1.0+3ae8eb9
Show
Mikayel Karapetyan added a comment - now the overbooked show gracefully exits. verified on Airtime 2.1.0+3ae8eb9
Mikayel Karapetyan made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Permalink
Daniel James added a comment -
Tested 2.2.0 snapshot from 9th October with fades of 0.5 and 3.5 seconds - overbooked shows are again being cut off without fades.
Show
Daniel James added a comment - Tested 2.2.0 snapshot from 9th October with fades of 0.5 and 3.5 seconds - overbooked shows are again being cut off without fades.
Daniel James made changes -
Status Closed [ 6 ] Open [ 1 ]
Assignee Mikayel Karapetyan [ migelek ] Martin Konecny [ mkonecny ]
Fix Version/s 2.2.0 [ 10363 ]
Fix Version/s 2.1.0 [ 10362 ]
Affects Version/s 2.2.0 [ 10363 ]
Affects Version/s 1.8.0 [ 10410 ]
Daniel James made changes -
Status Open [ 1 ] In Review [ 10000 ]
Issue Type Improvement [ 4 ] Bug [ 1 ]
Daniel James made changes -
Status In Review [ 10000 ] In Progress [ 3 ]
Martin Konecny made changes -
Assignee Martin Konecny [ mkonecny ] James Moon [ james.moon ]
Martin Konecny made changes -
Assignee James Moon [ james.moon ] Martin Konecny [ mkonecny ]
Martin Konecny made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Assignee Martin Konecny [ mkonecny ] Cliff Wang [ cliff.wang ]
Hide
Create a new review for changeset 795ffbbf631443b315819a8ec4968f3f6ad772e2
Martin Konecny <martin@thinkpad-t410> submitted changeset 795ffbbf631443b315819a8ec4968f3f6ad772e2 to 2.2.x-deb-official in airtime (1 file) - 22/Oct/12 8:36 PM

CC-2236: Overbooked shows do not respect default fade time
-move map_metadata after crossfade function

Show
Create a new review for changeset 795ffbbf631443b315819a8ec4968f3f6ad772e2
Martin Konecny <martin@thinkpad-t410> submitted changeset 795ffbbf631443b315819a8ec4968f3f6ad772e2 to 2.2.x-deb-official in airtime (1 file) - 22/Oct/12 8:36 PM
Hide
Permalink
Cliff Wang added a comment -
Fixed, verified at Airtime 2.2.0+d08b930:1351009785
Show
Cliff Wang added a comment - Fixed, verified at Airtime 2.2.0+d08b930:1351009785
Cliff Wang made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Tested by cliff.wang

People

  • Assignee:
    Cliff Wang
    Reporter:
    Daniel James
    Implemented by:
    Martin Konecny
    Tested by:
    Cliff Wang
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2d
Original Estimate - 2 days
Remaining:
2d
Remaining Estimate - 2 days
Logged:
Not Specified
Time Spent - Not Specified