Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
the XML-RPC methods added recently to the scheduler product are
actually not part of the scheduler daemon, nor are they tested
properly. only those XML-RPC methods are served by the scheduler
daemon, that are registered in
SchedulerDaemon::registerXmlRpcFunctions(). here, only 7 methods are
registered, whereas there are 18 XML-RPC functions by now: $ ls
products/scheduler/src/*Method.h | wc -l 18 also, there can be
serious integration issues with calling an XML-RPC method through XML-
RPC, instead of directly calling the functions of the methods class.
please register all XML-RPC methods in
SchedulerDaemon::registerXmlRpcFunctions(), and please add tests for
_all_ of them, by calling them through XML-RPC ADDITIONAL
INFORMATION: note that these tests don't make test that call the XML-
RPC methods directly redundant. both tests are needed. I saw that
even the existing XML-RPC test were removed from the CVS - I just
can't understand why this was done, as I asked you to do quite the
opposite - to add _all_ tests, not to remove already existing ones.
actually not part of the scheduler daemon, nor are they tested
properly. only those XML-RPC methods are served by the scheduler
daemon, that are registered in
SchedulerDaemon::registerXmlRpcFunctions(). here, only 7 methods are
registered, whereas there are 18 XML-RPC functions by now: $ ls
products/scheduler/src/*Method.h | wc -l 18 also, there can be
serious integration issues with calling an XML-RPC method through XML-
RPC, instead of directly calling the functions of the methods class.
please register all XML-RPC methods in
SchedulerDaemon::registerXmlRpcFunctions(), and please add tests for
_all_ of them, by calling them through XML-RPC ADDITIONAL
INFORMATION: note that these tests don't make test that call the XML-
RPC methods directly redundant. both tests are needed. I saw that
even the existing XML-RPC test were removed from the CVS - I just
can't understand why this was done, as I asked you to do quite the
opposite - to add _all_ tests, not to remove already existing ones.
SchedulerDaemon<unconsistentname>Test to Rpc<methodname>Test. This is
in preparation to adding some more, as
"SchedulerDaemonAddAudioClipToPlaylistMethodTest.cxx" would have been
too long.
oh, OK. then I renemaed the recently added
SchedulerDaemonGetVersionTest to RpcGetVersionTest as well. but
nevertheless, there are only 6 of these test, whereas there are 18
XML-RPC functions...
Note to self (or posterity): I haven't been able to find a way of
resetting the storage to its initial state, as
StorageClientFactory::getInstance()->configure( ... ); does not seem
to do that. I'm working on it.
Done. To fix the initialization issue, a resetStorage XML-RPC method
was added to the scheduler. Also, there is a login and a logout
method, added for consistency. Now there are 23 *Method.cxx's in
products/scheduler/src, all of them are loaded by the scheduler and
all of them have tests through XML-RPC.