Done -- it's called getSchedulerTime. It doesn't use push yet,
because I don't know how; will update it after I figure that out.
the implementation is bad. pleae read the man page for time.h: man
time.h The <time.h> header shall declare the structure tm,
which shall include at least the following members:
int tm_sec Seconds [0,60]. int tm_min Minutes
[0,59]. int tm_hour Hour [0,23]. int
tm_mday Day of month [1,31]. int tm_mon Month of
year [0,11]. int tm_year Years since 1900.
int tm_wday Day of week [0,6] (Sunday =0). int
tm_yday Day of year [0,365]. int tm_isdst Daylight
Savings flag. and note, that the field tm_year for the year 2004
is 104, the field tm_mon for December is not 12 but 11. please
update the implementation to return a proper time value.
also, please using functions from Core::TimeConversion. this piece of
code in GetSchedulerTimeMethod: ptime schedulerPTime
= second_clock::local_time(); date schedulerDate
= schedulerPTime.date(); time_duration schedulerTimeOfDay =
schedulerPTime.time_of_day(); struct tm schedulerTime;
schedulerTime.tm_year = schedulerDate.year(); schedulerTime.tm_mon
= schedulerDate.month(); schedulerTime.tm_mday =
schedulerDate.day(); schedulerTime.tm_hour =
schedulerTimeOfDay.hours(); schedulerTime.tm_min =
schedulerTimeOfDay.minutes(); schedulerTime.tm_sec =
schedulerTimeOfDay.seconds(); could rather be: ptime
schedulerPTime = TimeConversion::now(); struct tm
schedulerTime); from the above, TimeConversion::ptimeToTm() does
not exist yet, but other, similar conversion routines are there
It seems to me that the XmlRpc++ conversion routines are bad, then.
Surely, we want to return something like
<dateTime.iso8601>20041213T17:54:38</dateTime.iso8601> and not
<dateTime.iso8601>01041113T17:54:38</dateTime.iso8601> for December
hm. so, if you set mt_year = 104, it sends a date with the year
104, instead of 2004? are you sure? did you check? than please
patch the XmlRpc++ sources, and add the patch to the
tools/xmlrpc++/xmlrpc++-20040713/etc directory (there are already two
patches there), and modify install.sh to apply the new patch...
Well, I checked that it worked fine with the incorrect struct tm's.
Now I checked it properly, and it's actually even worse, it doesn't
even send "01041213" but "1041213", and if you set the year to 1899
(time.tm_year == -1), you'll get "-11213".
ok, please fix XmlRpc++ then, create a patch, add it to the
appropriate etc directory in tools, and post a bug report for them as
well, with the patch attached...
Well, that wasn't quite true -- the toXml() function handles the year
properly, but not the month; it's only the ostream& operator<<
function that bungles both.
OK, I think it works now.
ok, what do I need to do? do I need to recompile XmlRpc++ as well?
Yes, get the patch from cvs, and then run ./tools/xmlrpc++/xmlrpc-
And of course, recompile the core module, too. (This is really
annoying, having to reopen every time I want to add a note.)
great! can you please share the patch with the XmlRpc++ team as
well, e.g. here:
(you might even want to open a bug issue there, and point to the patch
as a solution) thanks...